Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch instructions to command mode guide #41363

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

holly-cummins
Copy link
Contributor

I missed the instructions on how to launch the app.

Advantages of putting them in:

  • People using this article have all the information they need, and don't need to try searching in their target folder to figure out the right invocation

Disadvantages of putting the commands in:

  • The information is available elsewhere, so this is duplication
  • The information isn't 'unique' to command mode

WDYT?

@quarkus-bot

This comment has been minimized.

Copy link

github-actions bot commented Jun 21, 2024

🙈 The PR is closed and the preview is expired.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense but I added a small comment.

docs/src/main/asciidoc/command-mode-reference.adoc Outdated Show resolved Hide resolved
I missed the instructions on how to launch the app.

Advantages of putting them in:
- People using this article have all the information they need, and don't need to try searching in their `target` folder to figure out the right invocation

Disadvantages of putting the commands in:
- The information is available elsewhere, so this is duplication
- The information isn't 'unique' to command mode

WDYT?
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 24, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 710edd8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 6887f85 into quarkusio:main Jun 25, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 25, 2024
@gsmet gsmet changed the title Add launch instructions to command mode guide? Add launch instructions to command mode guide Jun 26, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants