Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AutoCloseableDestroyer for the standalone search mapping bean #41325

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Use AutoCloseableDestroyer for the standalone search mapping bean #41325

merged 1 commit into from
Jun 24, 2024

Conversation

marko-bekhta
Copy link
Contributor

fixes #41316

I've checked this patch against search.quarkus.io, and the error log disappeared.

I can see that CloseableDestroyer is still used in OidcClientBuildStep and RestClientProcessor. I wonder whether we should just replace all usages with the AutoCloseableDestroyer and just remove CloseableDestroyer.

@yrodiere
Copy link
Member

Thanks, LGTM.

I can see that CloseableDestroyer is still used in OidcClientBuildStep and RestClientProcessor. I wonder whether we should just replace all usages with the AutoCloseableDestroyer and just remove CloseableDestroyer.

I wouldn't remove CloseableDestroyer, be it just for backwards compatibility. About the rest... not sure it's worth the trouble to be honest, but 🤷

@gsmet gsmet merged commit 5563a2c into quarkusio:main Jun 24, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 24, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
kind/bugfix
Projects
None yet
Milestone
3.12.1
3 participants
@marko-bekhta @yrodiere @gsmet