Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include several fixes related to the spring dependencies upgrading #41206

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

aureamunoz
Copy link
Member

@aureamunoz aureamunoz commented Jun 14, 2024

It also depends on quarkus-spring-data-api 3.2.SP2 release.

What does this PR?

This PR includes
Necessary classes from the Spring Data dependency that were missing in the previous release.
Refactored RepositoryMethodsImplementor:

  • Method Clashes: Adjusted the implementation to avoid conflicts with generated methods.
  • Improved Naming: Enhanced method names for better clarity and consistency.
  • Type Check Enhancement: Improved the condition that verifies the repository-to-implement type to ensure correct method generation.
  • Redundant Method Removal: Eliminated a redundant method to streamline the code.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/spring Issues relating to the Spring integration labels Jun 14, 2024
@quarkus-bot

This comment was marked as resolved.

@aureamunoz aureamunoz changed the title Include several fixes related to #40344 Include several fixes related to the spring dependencies upgrading Jun 14, 2024
@aureamunoz aureamunoz marked this pull request as ready for review June 17, 2024 07:50
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c62ce05.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment