-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vert.x 4.5.8 and Netty 4.1.110 #41155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check your IDE settings. A few star imports crawled in.
extensions/netty/runtime/src/main/java/io/quarkus/netty/runtime/graal/NettySubstitutions.java
Outdated
Show resolved
Hide resolved
cc @franz1981 who I know wants to try the new |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We would need to investigate the gRPC failure. My quick analysis indicates that it's a frame size issue. The response exceeded the default frame size. |
Is that reflection test thing that was disabled testing a feature that is really obscure? |
This comment has been minimized.
This comment has been minimized.
Yeah the reflection service from gRPC (which has nothing to do with Java reflection) is a way to discover gRPc services. However, it might fails because there is something else going on. We need to investigate. |
@franz1981 @geoand @vietj So, the gRPC issue comes from an incompatibility between grpc java and NEtty 4.1.111. PRevious versions of Netty work :-(. Need to see which commit can causes such a problem. We may have to stay on 4.1.110 for now. |
- bump Mutiny Bindings to 3.13.0 - bump Quarkus HTTP to 5.3.0 - update Netty SSL released substitutions
Status for workflow
|
The commit message seems misleading, given that Netty is no longer updated? |
@gastaldi Netty is updated but just to 4.1.110. |
@cescoffier is it something we want to shoe in 3.12? |
Ah doh, I missed the Netty bump, nvm |
@gsmet no :-) |
interesting, thanks
…On Thu, Jun 13, 2024 at 4:15 PM Clement Escoffier ***@***.***> wrote:
@franz1981 <https://github.com/franz1981> @geoand
<https://github.com/geoand> @vietj <https://github.com/vietj> So, the
gRPC issue comes from an incompatibility between grpc java and NEtty
4.1.111. PRevious versions of Netty work :-(. Need to see which commit can
causes such a problem.
We may have to stay on 4.1.110 for now.
—
Reply to this email directly, view it on GitHub
<#41155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCSOSBX7NK5IRA5FGO3ZHGSOLAVCNFSM6AAAAABJGA5ZPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVHAYDCOBYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@cescoffier so final verdict grpc/grpc-java#11284 (comment) |
we need to check if there is anything TBD in vertx
…On Mon, Jun 17, 2024 at 8:44 AM Francesco Nigro ***@***.***> wrote:
@cescoffier so final verdict grpc/grpc-java#11284 (comment)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Netty 4.1.111 causes a problem in gRPC. It seems to be a frame size issue. Need to be investigated.