Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RESTEasy Classic GZIP max input in native mode #41054

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jun 7, 2024

@michalvavrik
Copy link
Member Author

the failure is related, but it is also very strange as it is set via resteasy.gzip.max.input=5000 which suggests that current behavior is different when you do quarkus.resteasy.gzip.max.input=5000.

@michalvavrik michalvavrik force-pushed the feature/fix-gzip-max-input-in-native branch from 2db3308 to 0939f4a Compare June 7, 2024 11:51
@michalvavrik
Copy link
Member Author

michalvavrik commented Jun 7, 2024

the failure is related, but it is also very strange as it is set via resteasy.gzip.max.input=5000 which suggests that current behavior is different when you do quarkus.resteasy.gzip.max.input=5000.

It seems that previous PR added fix but that fix also failed contract established by GreetingResourceTest#testConfig unit test so if #39828 had tests, it would fail this CI. I assume that RESTEasy-specific tests have priority.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments inline. I'm not sure I understand what the problem is and what you are trying to test.

@michalvavrik
Copy link
Member Author

michalvavrik commented Jun 7, 2024

I added some comments inline. I'm not sure I understand what the problem is and what you are trying to test.

I am starting to think I should had created issue instead of PR. Sorry, it felt like very trivial. I am trying to fix GZIP in a native mode where it doesn't work. (AKA creating issue first is probably better approach to discuss the issue).

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR is perfectly fine, don't worry.

I'm good with the PR except for the added test that looks very odd to me. I would refrain from adding this.

We would probably need a test that actually checks the behavior, makes sure we don't have the warning and so on. But I'm not sure it's worth the hassle.

@quarkus-bot

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/fix-gzip-max-input-in-native branch from 0939f4a to 5d0a210 Compare June 7, 2024 15:06
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5d0a210.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@gsmet gsmet merged commit d7fe2f7 into quarkusio:main Jun 10, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 10, 2024
@gsmet
Copy link
Member

gsmet commented Jun 10, 2024

Thanks!

@michalvavrik michalvavrik deleted the feature/fix-gzip-max-input-in-native branch June 10, 2024 07:53
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.2 Jun 10, 2024
@gsmet gsmet modified the milestones: 3.11.2, 3.8.6 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants