Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven wrapper to 3.3.2 #40911

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

manofthepeace
Copy link
Contributor

@manofthepeace manofthepeace commented May 31, 2024

This updates the maven wrapper from 3.2.0 to 3.3.2.

The new version uses, by default, a script-only variant that does not need the jar, nor the maven downloader java source file. Type can be changed if needed. More info here; https://maven.apache.org/wrapper/index.html#usage-with-or-without-binary-jar

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform labels May 31, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@manofthepeace manofthepeace changed the title update maven wrapper to 3.3.2 Update maven wrapper to 3.3.2 May 31, 2024
@quarkus-bot

This comment has been minimized.

Copy link

github-actions bot commented May 31, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

@manofthepeace manofthepeace marked this pull request as draft May 31, 2024 15:14
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I added a small comment.
As for the failing tests: one you're happy with the changes, you need to do a quick build to install the artifacts and then run mvn clean verify -Dsnap in the modules with failing tests (and only them!).

.mvn/wrapper/maven-wrapper.properties Outdated Show resolved Hide resolved
@manofthepeace manofthepeace force-pushed the updateMvnWrapper branch 4 times, most recently from 1106014 to 7c0eb94 Compare June 18, 2024 13:20
@manofthepeace manofthepeace marked this pull request as ready for review June 18, 2024 13:26
@manofthepeace manofthepeace requested a review from gsmet June 18, 2024 13:26
@quarkus-bot

This comment has been minimized.

@manofthepeace
Copy link
Contributor Author

manofthepeace commented Jun 18, 2024

@gsmet looks like there was a OOM on windows;

2024-06-18T18:39:57.9988343Z java.lang.OutOfMemoryError: Java heap space
2024-06-18T18:39:57.9989333Z     at java.util.concurrent.ConcurrentHashMap.putVal (ConcurrentHashMap.java:1019)
2024-06-18T18:39:57.9990905Z     at java.util.concurrent.ConcurrentHashMap.put (ConcurrentHashMap.java:1006)
2024-06-18T18:39:57.9992017Z     at java.util.Collections$SetFromMap.add (Collections.java:5685)
2024-06-18T18:39:57.9993231Z     at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1492)
2024-06-18T18:39:57.9994309Z     at java.lang.Thread.run (Thread.java:840)
2024-06-18T18:39:57.9995086Z     at org.jboss.threads.JBossThread.run (JBossThread.java:483)
2024-06-18T18:39:57.9996384Z [ERROR] [org.jboss.threads.errors] Thread Thread[build-47,5,build group] threw an uncaught exception
2024-06-18T18:39:57.9997470Z java.lang.OutOfMemoryError: Java heap space
2024-06-18T18:39:57.9998420Z     at java.util.concurrent.ConcurrentHashMap.putVal (ConcurrentHashMap.java:1019)
2024-06-18T18:39:57.9999695Z     at java.util.concurrent.ConcurrentHashMap.put (ConcurrentHashMap.java:1006)
2024-06-18T18:39:58.0001157Z     at java.util.Collections$SetFromMap.add (Collections.java:5685)
2024-06-18T18:39:58.0002426Z     at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1492)
2024-06-18T18:39:58.0003558Z     at java.lang.Thread.run (Thread.java:840)
2024-06-18T18:39:58.0004372Z     at org.jboss.threads.JBossThread.run (JBossThread.java:483)
2024-06-18T18:39:58.0006022Z [ERROR] [org.jboss.threads.errors] Thread Thread[build-30,5,build group] threw an uncaught exception
2024-06-18T18:39:58.0007151Z java.lang.OutOfMemoryError: Java heap space
2024-06-18T19:47:09.4393633Z 2024-06-18 19:47:09
2024-06-18T19:47:09.4396305Z Full thread dump OpenJDK 64-Bit Server VM (17.0.11+9 mixed mode, sharing):

looks ok on my fork; https://github.com/manofthepeace/quarkus/actions/runs/9565837706

@quarkus-bot

This comment has been minimized.

@manofthepeace
Copy link
Contributor Author

@gsmet rebased this one, mind taking another look? This does not change the behaviour in how it used to work with the older wrapper; as noted in the comment here ; #40911 (comment)

@gsmet
Copy link
Member

gsmet commented Aug 9, 2024

Ah yes, sorry I totally forgot about it but it's something that would be nice to have in 3.14.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1c91616.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1c91616.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.traces.OpenTelemetryReactiveRoutesTest.nonRoot - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-8","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-8","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:821)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 57d9d84 into quarkusio:main Aug 9, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 9, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2024
@gsmet
Copy link
Member

gsmet commented Aug 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants