Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aesh (2.7 to 2.8.2) & aesh-readline (2.4 to 2.6) #40904

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Eng-Fouad
Copy link
Contributor

@Eng-Fouad Eng-Fouad commented May 30, 2024

This is a draft PR, until org.aesh:readline:2.5 is released and published to maven central (cc @stalep)

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label May 30, 2024
@Eng-Fouad Eng-Fouad changed the title Bump aesh-readline.version to 2.5 Bump aesh-readline.version from 2.4 to 2.5 May 30, 2024
@maxandersen
Copy link
Member

gah - missed that we actually need 2.6 not 2.5 to get the multirelease jar option. sorry for the noise.

@stalep got an ETA on 2.6 ?

@Eng-Fouad
Copy link
Contributor Author

gah - missed that we actually need 2.6 not 2.5 to get the multirelease jar option. sorry for the noise.

@stalep got an ETA on 2.6 ?

The reflection option was selected (and merged) over the multi-release option.

@Eng-Fouad Eng-Fouad changed the title Bump aesh-readline.version from 2.4 to 2.5 Bump aesh-readline.version from 2.4 to 2.6 Jun 25, 2024
@Eng-Fouad Eng-Fouad changed the title Bump aesh-readline.version from 2.4 to 2.6 Bump aesh (2.7 to 2.8.2) & aesh-readline (2.4 to 2.6) Jun 25, 2024
@Eng-Fouad Eng-Fouad marked this pull request as ready for review June 25, 2024 22:14
@Eng-Fouad
Copy link
Contributor Author

@gsmet @geoand Any chance this PR catches up and gets included in 3.12 release? :)

@geoand
Copy link
Contributor

geoand commented Jun 26, 2024

Is this change breaking in any way?

@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented Jun 26, 2024

Is this change breaking in any way?

I don't think so.

org.aesh:aesh: https://github.com/aeshell/aesh/compare/ef71ccb..f73a69f
org.aesh:readline: https://github.com/aeshell/aesh-readline/compare/8da0f40..d89da56

@geoand
Copy link
Contributor

geoand commented Jun 26, 2024

Looks safe, so I'm +1 for backporting

@geoand geoand added triage/backport triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 26, 2024
@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

Yeah makes sense to backport it but it will be in 3.12.1.

@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

(We built the 3.12.0 core artifacts last Wednesday)

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 26, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 499a8ce.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@gastaldi gastaldi merged commit 6a78f49 into quarkusio:main Jun 26, 2024
53 of 67 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 26, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 26, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
@Eng-Fouad Eng-Fouad deleted the patch-1 branch June 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/bugfix triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus devmode crashes on JDK >= 22 (Windows)
5 participants