Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically resolve Amazon Lambda arch #39914

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Art051
Copy link

@Art051 Art051 commented Apr 5, 2024

I encountered some issues running Quarkus lambda tutorials on Macbook with M2 Pro chip, and saw a similar issue reported here: #38715

This PR fixes these issues:

  • Extract the major version number for the build, appending to the Java runtime variable (quarkus supports 17 and 21, but 11 was hard coded previously) this will retrieve the version from the developer's device and append it to the necessary variable.
  • Set the native runtime to a variable for easier identification, with comment indicating where to find the current options
  • Added detection and setting of architecture based on machine being used to build the lambda

@quarkus-bot

This comment has been minimized.

@Art051
Copy link
Author

Art051 commented Apr 19, 2024

I fixed the merge conflict and marked as resolved and committed the change. But now there's a bot check error regarding the merge commit existing. But I've no idea how to resolve it, any pointers?

@Art051 Art051 force-pushed the native-quarkus-amazon-lambda-arch branch 4 times, most recently from b43af7b to 0953b63 Compare May 6, 2024 21:43
@Art051 Art051 force-pushed the native-quarkus-amazon-lambda-arch branch from 0953b63 to ef42748 Compare May 27, 2024 10:03
@Art051
Copy link
Author

Art051 commented May 27, 2024

@patriot1burke Any chance for a re-review?

… Added following to manage.sh:

- Extract the major version number for the build, appending to the Java runtime variable
- Set the native runtime to a variable for easier identification, with comment indicating where to find the current options
- Added detection and setting of architecture based on machine being used to build the lambda
@Art051 Art051 force-pushed the native-quarkus-amazon-lambda-arch branch from ef42748 to cf5774c Compare May 29, 2024 14:35
@Art051
Copy link
Author

Art051 commented May 29, 2024

@patriot1burke Apologies - it's requiring manual workflow approval by a maintainer too: CI Sanity Check Expected — Waiting for status to be reported

@gsmet
Copy link
Member

gsmet commented Jun 7, 2024

Sorry it took so long. I approved the workflow, let's wait for CI to get green and merge.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cf5774c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet changed the title Native quarkus amazon lambda arch linked to issue: https://github.com/quarkusio/quarkus/issues/38715 Dynamically resolve Amazon Lambda arch Jun 7, 2024
@gsmet gsmet merged commit 617a048 into quarkusio:main Jun 7, 2024
20 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 7, 2024
@Art051
Copy link
Author

Art051 commented Jun 7, 2024

Sorry it took so long. I approved the workflow, let's wait for CI to get green and merge.

No problem at all, cheers for sorting it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants