-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically resolve Amazon Lambda arch #39914
Conversation
This comment has been minimized.
This comment has been minimized.
I fixed the merge conflict and marked as resolved and committed the change. But now there's a bot check error regarding the merge commit existing. But I've no idea how to resolve it, any pointers? |
b43af7b
to
0953b63
Compare
0953b63
to
ef42748
Compare
@patriot1burke Any chance for a re-review? |
… Added following to manage.sh: - Extract the major version number for the build, appending to the Java runtime variable - Set the native runtime to a variable for easier identification, with comment indicating where to find the current options - Added detection and setting of architecture based on machine being used to build the lambda
ef42748
to
cf5774c
Compare
@patriot1burke Apologies - it's requiring manual workflow approval by a maintainer too: CI Sanity Check Expected — Waiting for status to be reported |
Sorry it took so long. I approved the workflow, let's wait for CI to get green and merge. |
Status for workflow
|
No problem at all, cheers for sorting it out! |
I encountered some issues running Quarkus lambda tutorials on Macbook with M2 Pro chip, and saw a similar issue reported here: #38715
This PR fixes these issues: