-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StorkClientRequestFilter exception handling #39731
Fix StorkClientRequestFilter exception handling #39731
Conversation
b4818e8
to
d40f0e8
Compare
13f87a7
to
0058eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thank you. LGTM. Let's see what CI says
b3fcc26
to
7f59def
Compare
This comment has been minimized.
This comment has been minimized.
cc @damianorenfer Could you please run the build or format command to have a proper code and then push it again? |
7f59def
to
bf01d15
Compare
Done, thanks! |
9a554b3
to
59189e7
Compare
This comment has been minimized.
This comment has been minimized.
59189e7
to
61699ac
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Exceptions were not caught properly because a Uni subscription was done outside a try-catch block.
61699ac
to
04cffc5
Compare
Status for workflow
|
Thanks for this work, we will get it backported to the next 3.9. |
Awesome thanks, can you also backport it to 3.8 (LTS)? Or should I do it? |
I marked it for backport to 3.8 too but we need some bake time in 3.9 first. |
Exceptions were not caught properly because a Uni subscription was done outside a try-catch block.