Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration based mapping of token roles to deployment-specific SecurityIdentity #39339

Merged

Conversation

michalvavrik
Copy link
Member

closes: #39269

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/vertx labels Mar 11, 2024
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc suggestion is proposed

@michalvavrik michalvavrik force-pushed the feature/simplify-role-mappings branch from dc985ba to d046f28 Compare March 12, 2024 13:00
@quarkus-bot

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/simplify-role-mappings branch from d046f28 to e5533d0 Compare March 12, 2024 14:02
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e5533d0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e5533d0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@sberyozkin sberyozkin merged commit a899875 into quarkusio:main Mar 13, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 13, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 13, 2024
Copy link

🙈 The PR is closed and the preview is expired.

@michalvavrik michalvavrik deleted the feature/simplify-role-mappings branch March 13, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation area/vertx kind/enhancement New feature or request triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.

Simplify configuration based mapping of token roles to deployment-specific SecurityIdentity
2 participants