Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions/upload-artifact and download-artifact to v4 #39170

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Bump actions/upload-artifact and download-artifact to v4 #39170

merged 2 commits into from
Mar 23, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Mar 4, 2024

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Mar 4, 2024
@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi gastaldi requested a review from gsmet March 4, 2024 22:09
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't update to a strict minor version or updating will be annoying.

But for now, we cannot do it. Not before hub4j/github-api#1791 has been merged.

@gsmet
Copy link
Member

gsmet commented Mar 22, 2024

I think we are now ready for upload/download-artifact@v4 as Quarkus GitHub App and Quarkus GitHub Action were updated to a version of GitHub API supporting v4 (hopefully). Let's give it another try.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 23, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 816a352.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 23, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 816a352.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet changed the title Bump actions/upload-artifact and download-artifact to latest versions Bump actions/upload-artifact and download-artifact to v4 Mar 23, 2024
@gsmet gsmet merged commit b8b6b2e into quarkusio:main Mar 23, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 23, 2024
@gastaldi gastaldi deleted the actions branch May 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure triage/flaky-test
Projects
None yet
Milestone
3.10.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@gastaldi @gsmet