-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Forwarded Parser syntax parsing case-insensitive #38580
Make the Forwarded Parser syntax parsing case-insensitive #38580
Conversation
As described on https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded, the forwarded header syntax parsing should be case-insensitive. It's not a real spec, but Kong is using `Proto` instead of `proto` and `For` instead of `for`.
@cescoffier should this be backported to 3.2? Thanks. |
@aloubyansky if possible yes, but because the behavior is not defined by a real spec - I won't fight for it :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cescoffier Thanks for the quick fix!
Is it already decided this goes to 3.7/3.8?
FYI @rsvoboda |
Status for workflow
|
@vmuzikar 3.7 yes - it is going to be backported. The Vert.x PR got merged too. |
As described on https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded, the forwarded header syntax parsing should be case-insensitive. It's not a real spec, but Kong is using
Proto
instead ofproto
andFor
instead offor
.