Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace {project-name} attribute in document title for downstream #38429

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 26, 2024

The downstream tool does not handle attributes in project title so we need to replace the attribute ourselves.

The attribute is only replaced in the document title, the rest of the document uses standard attributes.

I pushed an example in datasource.adoc.

/cc @quarkusio/documentation

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

🙈 The PR is closed and the preview is expired.

@gsmet gsmet force-pushed the replace-project-name-in-document-title branch from b5427a3 to 05b9b6c Compare January 26, 2024 18:22
The downstream tool does not handle attributes in project title so we
need to replace the attribute ourselves.

The attribute is only replaced in the document title, the rest of the
document uses standard attributes.

I pushed an example in datasource.adoc.
@gsmet gsmet force-pushed the replace-project-name-in-document-title branch from 05b9b6c to 22e6403 Compare January 26, 2024 18:23
@gsmet
Copy link
Member Author

gsmet commented Jan 26, 2024

@MichalMaler for now, I marked it for 3.7 only but I could be convinced to backport it to 3.2 if needed.

@gsmet gsmet merged commit 8d799c4 into quarkusio:main Jan 30, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 30, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.1 Jan 30, 2024
@gsmet gsmet modified the milestones: 3.7.1, 3.2.11.Final Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

1 participant