-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include RowSet properties file in native image #38370
Conversation
This fixes the `Resource javax/sql/rowset/rowset.properties not found` error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending checking the native executable size.
extensions/agroal/deployment/src/main/java/io/quarkus/agroal/deployment/AgroalProcessor.java
Show resolved
Hide resolved
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
After the change:
Before the change:
|
Ideally, it would be nice if we had that only when the RowSet API is required (maybe split in a different extension in the future?), but I am not sure it's worth the effort |
Yeah, I agree it's not worth the effort given the very small size increase. Thanks for checking! |
Follow-up on #38362. This fixes the
Resource javax/sql/rowset/rowset.properties not found
error.I've tested with the reproducer project in apache/camel-quarkus#5666 (comment) provided by @turing85 and it works.