Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RowSet properties file in native image #38370

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jan 24, 2024

Follow-up on #38362. This fixes the Resource javax/sql/rowset/rowset.properties not found error.

I've tested with the reproducer project in apache/camel-quarkus#5666 (comment) provided by @turing85 and it works.

This fixes the `Resource javax/sql/rowset/rowset.properties not found` error
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending checking the native executable size.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 24, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi
Copy link
Contributor Author

After the change:

  33.76MB (42.65%) for code area:    52,442 compilation units
  44.47MB (56.19%) for image heap:  407,253 objects and 741 resources
 938.98kB ( 1.16%) for other data
  79.14MB in total

Before the change:

  33.75MB (42.65%) for code area:    52,438 compilation units
  44.47MB (56.19%) for image heap:  407,193 objects and 739 resources
 941.20kB ( 1.16%) for other data
  79.14MB in total

@gastaldi gastaldi requested a review from gsmet January 24, 2024 15:08
@gastaldi
Copy link
Contributor Author

gastaldi commented Jan 24, 2024

Ideally, it would be nice if we had that only when the RowSet API is required (maybe split in a different extension in the future?), but I am not sure it's worth the effort

@gsmet gsmet merged commit f099ed3 into quarkusio:main Jan 24, 2024
40 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 24, 2024
@gastaldi gastaldi deleted the rowset_take_two branch January 24, 2024 15:11
@gsmet
Copy link
Member

gsmet commented Jan 24, 2024

Yeah, I agree it's not worth the effort given the very small size increase.

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JdbcTemplate is missing a resource bunde for native
3 participants