Emitter support and reactive dependency updates #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the emitter support
mkouba
requested changes
Apr 4, 2019
...ava/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java
Show resolved
Hide resolved
...ava/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java
Outdated
Show resolved
Hide resolved
Use constants for DOTNAME
|
@mkouba Code updated. |
mkouba
reviewed
Apr 4, 2019
| .asClass() | ||
| .methods()) { | ||
| ClassInfo ci = bean.getTarget() | ||
| .orElseThrow(() -> new IllegalStateException("Target expected")).asClass(); |
There was a problem hiding this comment.
If bean.isClassBean()==true the target is never empty.
mkouba
reviewed
Apr 4, 2019
| if (annotationStore.hasAnnotation(method, NAME_INCOMING) | ||
| || annotationStore.hasAnnotation(method, NAME_OUTGOING)) { | ||
| // TODO: validate method params and return type? | ||
| mediatorMethods.produce(new MediatorBuildItem(bean, method)); | ||
| LOGGER.debugf("Found mediator business method %s declared on %s", method, bean); | ||
| } | ||
| } | ||
|
|
||
| for (FieldInfo field : ci.fields()) { |
There was a problem hiding this comment.
Hm, this means that we only support field injection. In fact, we can simply iterate over all injection points:
for (InjectionPointInfo injectionPoint : validationContext.get(Key.INJECTION_POINTS)) {
// TODO
}I'll try to update this PR in a moment...
|
@cescoffier Pls review my updates... |
mkouba
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsumeEvent.blocking, new axle method)