Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock injection point metadata for beans injected into test classes #1813

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Mock injection point metadata for beans injected into test classes #1813

merged 1 commit into from
Apr 2, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 2, 2019

@mkouba
Mock injection point metadata for beans injected into test classes
d03937d 
- implement BeanManager.getInjectableReference() and modify
ArcTestResourceProvider
- resolves quarkusio#1802
@mkouba mkouba added this to the 0.13.0 milestone Apr 2, 2019
@mkouba mkouba requested review from manovotn and geoand April 2, 2019 13:53
@mkouba
Copy link
Contributor Author

mkouba commented Apr 2, 2019

@sarxos Could you pls verify this PR with your app?

@sarxos
Copy link
Contributor

sarxos commented Apr 2, 2019

@mkouba Sure thing. I'm checking it out now.

@sarxos
Copy link
Contributor

sarxos commented Apr 2, 2019

@mkouba It works like a charm :) All my test cases are passing now!

geoand
geoand approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sarxos
sarxos approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@sarxos sarxos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

@gsmet
Copy link
Member

gsmet commented Apr 2, 2019

Merging then, thanks everyone!

@gsmet gsmet merged commit 86a4a9d into quarkusio:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarxos sarxos sarxos approved these changes

@geoand geoand geoand approved these changes

@manovotn manovotn Awaiting requested review from manovotn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

No qualifiers available from InjectionPoint (always EMPTY)
4 participants
@mkouba @sarxos @gsmet @geoand