Allow beans to be injected in tests even if they aren't used in the application #1804
Conversation
geoand
changed the title
...oyment/src/main/java/io/quarkus/deployment/test/TestDefiningAnnotationBuildItemProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good. In theory, if we want a more correct solution we could create a TestAnnotationBuildItem in the core-deployment, and add another build step here and then the TestsAsBeanDefiningAnnotationsProcessor would consume this build item.
|
@mkouba do you think we should make that change now or in the future if we have more changes to do around testing and Arc? |
|
@geoand It's up to you ;-). The change should be pretty straightforward. If we decide to go with hard-coded values we should at least add some comment about the possible improvement. |
|
@mkouba Let me think about for a few minutes :P. The change is indeed super easy to make and I the reason I think it's good to do is to keep things consistent with what we have done so far |
|
@mkouba PR updated 😉 . I decided to change it because the solution you proposed is more in line with how similar cases have been handled so far. |
|
Thanks, looks good! Let's wait for CI. |
geoand
dismissed
stuartwdouglas’s stale review
@mkoube has reviewed the latest version
Fixes: #1749