added test section and updates to reflect plugin changes #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
requested changes
Mar 20, 2019
| } | ||
| ---- | ||
|
|
||
| <1> The {project-name} plugin needs to be applied. | ||
| <2> This dependency is needed for a REST application similar to the getting started example. | ||
| Since {project-name} has no container we also need this dependency for running tests, to provide this we use the `implementation` configuration. |
There was a problem hiding this comment.
container is misleading here. Maybe you can simplify as:
The second dependency is used for running our tests. The test framework starts the servers automatically.
There was a problem hiding this comment.
Hm, it's both for tests and compile, it's the closest thing we get to provided in Gradle. My thought was to explain why we use the implementation configuration. The main reason is that we need it both for the compile and test. I see that the wording isn't great....
How about: " Quarkus also need this dependency for running tests etc..." ?
cescoffier
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this makes it easier to start with Gradle on Quarkus. It should address #1458. Built from master + #1583 I can successfully run the getting-started QuarkusTests from the CLI and Intellij.