Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REST client CI failure #1567

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 18, 2019

I'm not sure the first commit is needed but we usually register the service file manually when it's required to be included in the native image.

The second commit is the one that fixes the issue as, apparently, we now don't include the META-INF/microprofile-config.properties file into the native image.

@gsmet gsmet force-pushed the fix-rest-client-incoming-headers branch from 08be208 to 25e7559 Compare March 19, 2019 00:26
@gsmet gsmet changed the title [DO NOT MERGE] Fix current CI failure Fix REST client CI failure Mar 19, 2019
@gsmet gsmet requested a review from dmlloyd March 19, 2019 00:29
Copy link
Contributor

@starksm64 starksm64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that only the application.properties change was needed to get the RestClientITCase to pass, but the explicit provider addition does not hurt.

@starksm64 starksm64 merged commit 8019508 into quarkusio:master Mar 19, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants