-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for usage of @ConfigProperty on fields without @Inject #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I'd rather wait for someone experienced with Quarkus to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a new Processor
class? I would move the method to the ConfigBuildStep
. Otherwise looks good?
@mkouba good point, I didn't realize I can stuff multiple build steps in there. |
Looks good now. Let's wait for CI checks... |
quarkusio/quarkus#1554 made it redundant to have @Inject on a @ConfigProperty
quarkusio#1554 made it redundant to have @Inject on a @ConfigProperty Follows up on: quarkusio#1315
quarkusio#1554 made it redundant to have @Inject on a @ConfigProperty Follows up on: quarkusio#1315
No description provided.