Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing build due to path relative to root module dir rather than project module dir #1494

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Fix failing build due to path relative to root module dir rather than project module dir #1494

merged 2 commits into from
Mar 15, 2019

Conversation

jnizet
Copy link
Contributor

@jnizet jnizet commented Mar 14, 2019 •
edited by cescoffier
Loading

No description provided.

geoand
geoand approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests will pass :)

@gsmet
Copy link
Member

gsmet commented Mar 14, 2019

The build is failing on Windows because we should call gradlew.bat:

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.6.0:exec (gradle-integration-test) on project quarkus-gradle-plugin-integration-test: Command execution failed. Cannot run program "D:\a\1\s\devtools\gradle-it\..\gradle\gradlew" (in directory "D:\a\1\s\devtools\gradle-it"): CreateProcess error=193, %1 is not a valid Win32 application -> [Help 1]

Could you fix that? It's preexisting to your patch.

The failures on Linux are unrelated AFAICS. We really need to fix this Nexus timeout issue :/

gsmet
gsmet requested changes Mar 14, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing on Windows (was probably also failing before but did not break the build for whatever reason...)

@stuartwdouglas stuartwdouglas merged commit c8feafa into quarkusio:master Mar 15, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 15, 2019
@cescoffier cescoffier changed the title Fix failing build due to path relative to root module dir rather than… Fix failing build due to path relative to root module dir rather than project module dir Mar 20, 2019
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
@quintesse
feat: added support for specifying native options (quarkusio#1494)
6e6312d 
Added both `//NATIVE_OPTIONS` and `--native-option`.
Also enabled `//COMPILE_OPTIONS` for both Kotlin and Groovy sources.
Updated docs to prefer the newer tag and option names.

Fixes quarkusio#1493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jnizet @gsmet @geoand @stuartwdouglas