Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add useJUnitPlatform to build.gradle #1489

Closed

Conversation

vorburger
Copy link
Contributor

so that the (existing) QuarkusPluginTest unit test actually really runs.

FYI the POM here is pom, so it's Gradle (not Maven) which
actually builds the quarkus-gradle-plugin sources, and runs its test.

This has nothing to do with the (new) ../gradle-it integration test.

so that the (existing) QuarkusPluginTest unit test actually really runs.

FYI the POM here is <packaging>pom, so it's Gradle (not Maven) which
actually builds the quarkus-gradle-plugin sources, and runs its test.

This has nothing to do with the (new) ../gradle-it integration test.
@vorburger
Copy link
Contributor Author

vorburger commented Mar 14, 2019

@stalep this was noticed by @jnizet over in #1442

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s wait for CI but it looks good.

@geoand
Copy link
Contributor

geoand commented Mar 14, 2019

Restarting native tests....

@gsmet
Copy link
Member

gsmet commented Mar 14, 2019

This one was included in #1492 .

Closing.

@gsmet gsmet closed this Mar 14, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants