programmatic client generation for MP Rest Client, fixes #1317 #1486
Conversation
|
@michalszynkiewicz tests are failing |
|
@geoand the tests were fine, a couple unused imports sneaked in |
|
@michalszynkiewicz cool :) |
|
@michalszynkiewicz I assume that when this is merged the quickstart will need to be updated as well? |
|
@geoand what's currently in the quickstarts will work. They don't cover programmatic creation of the client, I don't know if it's something that should be/is worth adding to the quickstarts |
|
Got it, thanks! Maybe then we could add a section about the improved support you added in the doc about the rest-client? |
|
the native build failed with a timeout on downloading smallrye metrics artifact from the jboss nexus. |
There was a problem hiding this comment.
@michalszynkiewicz the implementation looks good.
I added 2 very minor comments, could you adjust and I'll merge?
| * | ||
| * @author Michal Szynkiewicz, michal.l.szynkiewicz@gmail.com | ||
| * <br> | ||
| * Date: 3/15/19 |
There was a problem hiding this comment.
I would drop that. We don't really use that, we have the git history.
|
|
||
| == Further reading | ||
|
|
||
| link:https://download.eclipse.org/microprofile/microprofile-rest-client-1.2.1/microprofile-rest-client-1.2.1.html[MicroProfile Rest Client specification] |
There was a problem hiding this comment.
Very minor nitpicking: even if there is only one element, I would use a list to have a better rendering.
No description provided.