Support for Microsoft SQL Server [JDBC] #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Mar 12, 2019
| //Not strictly necessary when using Agroal, as it also registers | ||
| //any JDBC driver being configured explicitly through its configuration. | ||
| //We register it for the sake of people not using Agroal. | ||
| final String driverName = "com.microsoft.sqlserver.jdbc.SQLServerDriver"; |
There was a problem hiding this comment.
Can't you use the class itself to get the name? That would seem more future proof.
There was a problem hiding this comment.
Tradeoff choices.
it's not like they can change the driver name without breaking a million apps either.. I prefer to not initialize the class.
| <groupId>com.microsoft.azure</groupId> | ||
| <artifactId>adal4j</artifactId> | ||
| <version>1.6.3</version> | ||
| <exclusions> |
There was a problem hiding this comment.
If you want to exclude all its dependencies, you can use:
<groupId>*</groupId>
<artifactId>*</artifactId>
There was a problem hiding this comment.
unfortunately it wasn't possible to exclude them all :(
gsmet
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready to be used.
There are some follow up things to discuss, but I don't think these should block merging the feature: