Register return types on REST Interface methods for reflection #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +175,11 @@ void processInterfaces(CombinedIndexBuildItem combinedIndexBuildItem, | |||
| reflectiveClass.produce(new ReflectiveClassBuildItem(true, false, iName)); | |||
| } | |||
|
|
|||
| // Register Interface return types for reflection | |||
| for (Type returnType : returnTypes) { | |||
| reflectiveClass.produce(new ReflectiveClassBuildItem(false, false, returnType.toString())); | |||
There was a problem hiding this comment.
This should be ReflectiveHeirachyBuildItem, so it will attempt to also register super classes. You will also need to register methods (and probably fields) so that the serializer can actually set the values.
stuartwdouglas
approved these changes
Mar 6, 2019
gsmet
reviewed
Mar 6, 2019
| @@ -147,6 +154,16 @@ void processInterfaces(CombinedIndexBuildItem combinedIndexBuildItem, | |||
| continue; | |||
| } | |||
| interfaces.put(theInfo.name(), theInfo); | |||
|
|
|||
| // Find Return types | |||
| for (MethodInfo method : theInfo.methods()) { | |||
There was a problem hiding this comment.
You should only consider the methods with @GET, @POST..., shouldn't you?
Take a look at the RESTEasy processor, that might help.
There was a problem hiding this comment.
Because otherwise you will register unnecessary reflection if you have other methods.
There was a problem hiding this comment.
As these are interfaces, that's a lot less likely to happen than in a regular JAX-RS Resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254