Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make devmode check for application.properties changes as well #1250

Closed
wants to merge 1 commit into from
Closed

Make devmode check for application.properties changes as well #1250

wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 6, 2019

No description provided.

@geoand
Copy link
Contributor Author

geoand commented Mar 6, 2019

This is an alternative to #1249

@stuartwdouglas
Copy link
Member

I don't think we need the extra test, these tests are slow and the code path is exactly the same no matter what the file is called.

@geoand
Copy link
Contributor Author

geoand commented Mar 6, 2019

I don't think we need the extra test, these tests are slow and the code path is exactly the same no matter what the file is called.

Cool. I added the test basically so no future refactoring would break the feature by accident but of course the chances of that are very slim.

@geoand geoand deleted the appprops-reload branch March 6, 2019 08:39
@gsmet gsmet added this to the 0.11.0 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @stuartwdouglas @gsmet