Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize packages to have proper API packages #1237

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Reorganize packages to have proper API packages #1237

merged 2 commits into from
Mar 6, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 5, 2019 •
edited
Loading

@mkouba can you check the API you mentioned on Zulip are alright?

I also pushed the @DataSource qualifier to API.

Some details:

  • deployment root package for all the extension deployment artifacts
  • runtime root package for the extension runtime artifacts...
  • except for the runtime API which are under io.quarkus.<extension>

@gsmet gsmet requested a review from mkouba March 5, 2019 17:47
@gsmet gsmet mentioned this pull request Mar 5, 2019
Merged
@mkouba
Copy link
Contributor

mkouba commented Mar 6, 2019

Looks good but there are some conflicts :-(. Could you rebase pls?

@stuartwdouglas stuartwdouglas merged commit eced388 into quarkusio:master Mar 6, 2019
@gsmet gsmet added this to the 0.11.0 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba Awaiting requested review from mkouba

@emmanuelbernard emmanuelbernard Awaiting requested review from emmanuelbernard

Assignees
No one assigned
Labels
priority/urgent
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @mkouba @stuartwdouglas