Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate jboss-logmanager-embedded #1197

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Use separate jboss-logmanager-embedded #1197

merged 1 commit into from
Mar 5, 2019

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Mar 5, 2019

No description provided.

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 5, 2019

/cc @cescoffier

@cescoffier
Copy link
Member

hey, no CI! How confident are you?

@rsvoboda
Copy link
Member

rsvoboda commented Mar 5, 2019

Where does jboss-logmanager-embedded live ?
I think it should be under https://github.com/jboss-logging

@stuartwdouglas
Copy link
Member

This built fine for me locally in JVM mode.

@Sanne Sanne self-assigned this Mar 5, 2019
@Sanne
Copy link
Member

Sanne commented Mar 5, 2019

I'l be testing this locally with all native modules

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 5, 2019

Where does jboss-logmanager-embedded live ?
I think it should be under https://github.com/jboss-logging

It's under https://github.com/dmlloyd - I don't care where it lives as long as it's not a lot of work, but I don't want to put it anyplace where anyone expects that there will ever be more than one or two releases.

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 5, 2019

hey, no CI! How confident are you?

I did a build with no-native and it was OK. It's the same code as what was in the original tree.

@cescoffier cescoffier merged commit ee4c9f4 into quarkusio:master Mar 5, 2019
@cescoffier cescoffier deleted the jblm branch March 5, 2019 10:14
@rsvoboda
Copy link
Member

rsvoboda commented Mar 5, 2019 •
edited
Loading

there will ever be more than one or two releases

So Quarkus will use in the end non-embedded logmanager ?
If not we should put it under logging organization because of product / productization ...

@dmlloyd
Copy link
Member Author

dmlloyd commented Mar 5, 2019

there will ever be more than one or two releases

So Quarkus will use in the end non-embedded logmanager ?

Yes.

If not we should put it under logging organization because of product / productization ...

It will never be productized.

@stuartwdouglas stuartwdouglas added this to the 0.11.0 milestone Mar 6, 2019
@gastaldi gastaldi mentioned this pull request Sep 6, 2019
Closed
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
@allcontributors
docs: add scottkurz as a contributor for bug (quarkusio#1197)
82de0ae 
* docs: update CONTRIBUTORS.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees

@Sanne Sanne

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dmlloyd @cescoffier @rsvoboda @stuartwdouglas @Sanne