Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1181 - Minor fixes for Panache documentation #1183

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Issue 1181 - Minor fixes for Panache documentation #1183

merged 2 commits into from
Mar 5, 2019

Conversation

emmanuelbernard
Copy link
Member

Also I wonder if it should be Panache, Panache JPA or Panache Hibernate. I see you use either fo the first two. I personally would favor 1 and 3.

@emmanuelbernard
Copy link
Member Author

@FroMage Food for you

@emmanuelbernard
Copy link
Member Author

for issue #1181

gsmet
gsmet reviewed Mar 4, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted two typos. Looks like a nice improvement otherwise.

docs/src/main/asciidoc/panache-jpa-guide.adoc Outdated Show resolved Hide resolved
@gsmet @FroMage
Update docs/src/main/asciidoc/panache-jpa-guide.adoc
3761e2b 
Co-Authored-By: FroMage <stef@inforealm.org>
FroMage
FroMage reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@stuartwdouglas stuartwdouglas merged commit a8a0dba into quarkusio:master Mar 5, 2019
@FroMage
Copy link
Member

FroMage commented Mar 5, 2019

@emmanuelbernard so we went with Panache JPA because very soon we will have Panache RX. But we can rename it to Panache ORM or Panache Hibernate if you prefer.

@stuartwdouglas stuartwdouglas added this to the 0.11.0 milestone Mar 6, 2019
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
@michael-simons
Use tagName instead of projectVersion (quarkusio#1183)
443871e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage left review comments

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@emmanuelbernard @FroMage @gsmet @stuartwdouglas