Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for a full tooling guide #1177

Merged
merged 6 commits into from
Mar 4, 2019
Merged

Conversation

emmanuelbernard
Copy link
Member

See #1156

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a couple of typos.

Looks good otherwise.

docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
@gsmet
Copy link
Member

gsmet commented Mar 4, 2019

Pushed an additional commit with typo fixes.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few comments. Probably old stuff that we missed.

docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
The project is either generated in the current directory or in a directory named after the passed artifactId.
If the current directory is empty, the project is generated in-place.

A `Dockerfile` is also generated in `src/main/docker`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is PR to create 2 dockers files: 1 for native and 1 for java mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we will postpone that one, I think.

docs/src/main/asciidoc/tooling.adoc Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
@gsmet
Copy link
Member

gsmet commented Mar 4, 2019

@cescoffier I addressed your comments and fixed a few more things.

Properties are not inherited from the BOM so unfortunately, we need to
define the versions twice.

As the documentation versions will be defined in the website, they
will be duplicated anyway so that's not an issue.
@gsmet gsmet added this to the 0.11.0 milestone Mar 4, 2019
@gsmet gsmet merged commit 35bc98c into quarkusio:master Mar 4, 2019
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
* docs: update CONTRIBUTORS.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants