-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for a full tooling guide #1177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a couple of typos.
Looks good otherwise.
Pushed an additional commit with typo fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few comments. Probably old stuff that we missed.
The project is either generated in the current directory or in a directory named after the passed artifactId. | ||
If the current directory is empty, the project is generated in-place. | ||
|
||
A `Dockerfile` is also generated in `src/main/docker`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is PR to create 2 dockers files: 1 for native and 1 for java mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we will postpone that one, I think.
@cescoffier I addressed your comments and fixed a few more things. |
Properties are not inherited from the BOM so unfortunately, we need to define the versions twice. As the documentation versions will be defined in the website, they will be duplicated anyway so that's not an issue.
* docs: update CONTRIBUTORS.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
See #1156