Remove the "sleep" calls from the DevMojoIT #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanne
reviewed
Mar 4, 2019
| @@ -303,7 +318,10 @@ public void testThatNewBeanAreDiscovered() throws IOException, MavenInvocationEx | |||
| .pollDelay(1, TimeUnit.SECONDS) | |||
| .atMost(1, TimeUnit.MINUTES).until(() -> getHttpResponse("/app/hello").contains("message")); | |||
|
|
|||
| sleep(); | |||
| await() | |||
| .pollDelay(1, TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
Should we wait for a much longer maximum time? The tests still fail for me.
There was a problem hiding this comment.
Yes, we can extend. Did you figure out a value that works for you?
There was a problem hiding this comment.
sorry that was confusing. 1s works for me, I'm having a different issue: this doesn't trigger at all
I only mentioned to use a higher value as it seems a bit silly to wait maximum 1s with a poll time of 1s, I can see this failing on slower CIs
Sanne
approved these changes
Mar 4, 2019
|
thanks @cescoffier ! Didn't fix the problem I have but it helps me to understand the code 👍 I'll have a look later tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.