Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on website data: community #1005 #1138

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Mar 1, 2019

No description provided.

@FroMage
Copy link
Member Author

FroMage commented Mar 1, 2019

Links are bogus for now.


== Code and issue tracker

The source code is hosted on https://github.com/jbossas/protean-shamrock/[GitHub].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using bogus links when we know already what they will be?

https://github.com/quarkusio/quarkus right @n1hility ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't know. I also don't know where our guides and docs will sit, how how our zulip channel will be named.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fair enough 👍

Copy link
Member

@gsmet gsmet Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea is to use the attributes that @starksm64 prepared for us. They are all documented in the README.adoc (the one in src/main/asciidoc).

I did that and added a few more for our needs.

@FroMage be careful, I pushed additional commits to your branch so be sure to get them if you want to update things.

If you are an extension developers or want to contribute to {project-name} development, join our mailing list either:

- by emailing quarkus-dev+subscribe@googlegroups.com
- by visiting to the Google Groups page https://groups.google.com/d/forum/quarkus-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we say that we would NOT use Google Groups ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have said that too, but @emmanuelbernard said so in the #1005 issue :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me is afraid of lead hammer blows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanne we do use a dev mailing list for what protean-dev is today. And we need it in the open.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand we need a mailing list. And go ahead with google groups, I don't care.. just pointing out that previously you said we would not do that, I missed the memo about change of plans.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK with my 2 additional commits.

@FroMage could you check them, please?

@n1hility
Copy link
Member

n1hility commented Mar 2, 2019

@FroMage @Sanne yes quarkusio/quarkus is correct.

I’ll merge for now and this can be updated further in other PRS

@n1hility n1hility merged commit 8a1f7ab into quarkusio:master Mar 2, 2019
@gsmet gsmet added this to the 0.11.0 milestone Mar 2, 2019
@FroMage
Copy link
Member Author

FroMage commented Mar 4, 2019

OK thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants