Init params and custom instance factories to the ServletBuildItem #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Feb 26, 2019
|
|
||
| import org.jboss.builder.item.MultiBuildItem; | ||
|
|
||
| import io.undertow.servlet.api.InstanceFactory; | ||
|
|
||
| public final class ServletBuildItem extends MultiBuildItem { |
There was a problem hiding this comment.
As an aside, I wonder if we should have builders for these complex build items, so they can be immutable?
| return instanceFactory; | ||
| } | ||
|
|
||
| public ServletBuildItem setInstanceFactory(InstanceFactory<? extends Servlet> instanceFactory) { |
There was a problem hiding this comment.
Is this something that should be set on creation?
stuartwdouglas
force-pushed
the
servlet-build-items-fixes
branch
from
3856b4e
to
e5cc659
Compare
cescoffier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.