logout.backchannel.path fails when http.root-path is present - Again

[AB-xdev]

Describe the bug

Basically the same problem as in #42483 happens again with the latest release (3.14.1).
The fix was likely incomplete, as we also encountered the problem in 3.13.3.

How to Reproduce?

We created a full PoC repo with detailed information, how the bug can be reproduced:
https://github.com/AB-xdev/quarkus-backchannel-logout-poc

Quarkus version or git rev

3.14.1

[geoand]

cc @sberyozkin

[sberyozkin]

Thanks @AB-xdev for preparing a POC repo.

[AB-xdev]

Problem is likely caused by

quarkus/extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/BackChannelLogoutHandler.java

Line 49 in 15a7158

router.route(getRootPath() + oidcTenantConfig.logout.backchannel.path.get())

While debugging RouterImpl#route I noticed that nearly all paths are always registered without the /backend-rootpath-prefix.
Only the backchannel-logout endpoints are inconsistent in this behavior and get registered with it.

When I use the debugger to replace /backend/oidc/wim/back-channel-logout with /oidc/wim/back-channel-logout during registration and then perform a backchannel logout via keycloak everything works as expected:

2024-09-03 17:03:22,329 DEBUG [io.qua.oid.run.BackChannelLogoutHandler] (vert.x-eventloop-thread-4) Back channel logout request for the tenant wim received
// No further errors
// Browser gets redirect to login during next request

[sberyozkin]

@AB-xdev Do you have some concrete examples in the Quarkus code where the root path is not used at the router registration but which can be successfully accessed with the http root path configured ?

[sberyozkin]

@cescoffier Hi Clement, what is the right way to deal with the HTTP root when using router.route, do we use it HTTP route directly to calculate the root path or is it automatically implied ?

[cescoffier]

it should be automatically mounted at the right path - except if the route is an absolute route.

[sberyozkin]

Thanks @cescoffier, so we'll just need to remove that HTTP root prefix.
@AB-xdev Hi, since you are already looking at that code, can you give me a favor, and remove getRootPath() at the route setup and confirm with your POC it fixes it ? PR will be welcomed too, thanks

[sberyozkin]

@AB-xdev I'll add a proper test as well to support your PR should you go with it, thanks

[AB-xdev]

I created a PR here that removes the 16 characters: #43000

Note however that setting it up took me longer than doing the actual change so for future I would appreciate it if you could do small changes instead :)

[sberyozkin]

Thanks @AB-xdev It is not about a number of characters but about the community willing to help, we can't just always momentarily switch off from whatever we do and fix the current issue, so well done for giving it a go.

[AB-xdev]

Rechecked it and can confirm that this is fixed indeed now fixed in 1.14.3.

Thank you for the very quick response and release 👍

[geoand]

Great, thanks for checking!