ExtLogRecord creation is more costly following the update to SmallRye Common 2.4.0
#42858
Labels
area/smallrye
triage/upstream
Used for issues which are caused by issues in upstream projects/dependency
Milestone
Comments
|
/cc @Ladicek (smallrye), @jmartisk (smallrye), @phillip-kruger (smallrye), @radcortez (smallrye) |
radcortez
added
the
triage/upstream
|
Ideally it's something we should address before 3.15 is released as it could be considered a regression compared to previous LTS (3.8). |
dmlloyd
added a commit
to dmlloyd/smallrye-common
that referenced
this issue
Aug 29, 2024
Fixes performance problem when creating log records or other things which frequently request the PID or process name. See quarkusio/quarkus#42858 for more info.
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Sep 2, 2024
Fixes quarkusio#42858. Fixes part of quarkusio#42248. (cherry picked from commit 7caa6d5)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Sep 3, 2024
Fixes quarkusio#42858. Fixes part of quarkusio#42248. (cherry picked from commit 7caa6d5)
danielsoro
pushed a commit
to danielsoro/quarkus
that referenced
this issue
Sep 20, 2024
Fixes quarkusio#42858. Fixes part of quarkusio#42248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was having a look at #42855 , which actually creates quite some log records (but not something that is completely weird either).
While the very visible issue looks fixed in
main, I still had the impression things were a bit slower.I had a look at some flame graphs and stumbled upon the
ExtLogRecordcreation being a lot more costly inmain:ExtLogRecordcreation in3.11.xExtLogRecordcreation inmainThe problem is due to the upgrade of SmallRye Common and from what I can see to this patch: smallrye/smallrye-common@016ad93 which removes the cache for the process name.
/cc @dmlloyd
The text was updated successfully, but these errors were encountered: