Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dead simple way to do basic auth in REST Client #38565

Closed
geoand opened this issue Feb 2, 2024 · 4 comments · Fixed by #38603
Closed

Add a dead simple way to do basic auth in REST Client #38565

geoand opened this issue Feb 2, 2024 · 4 comments · Fixed by #38603
Assignees
@geoand
Labels
area/rest-client kind/enhancement New feature or request
Milestone
3.9.0.CR1

Comments

@geoand
Copy link
Contributor

geoand commented Feb 2, 2024

Description

Basic Auth is more complicated than it has too be, let's change that

Implementation ideas

No response
@geoand geoand added kind/enhancement New feature or request area/rest-client labels Feb 2, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 2, 2024

/cc @cescoffier (rest-client)

@FroMage
Copy link
Member

FroMage commented Feb 2, 2024

How complicated does it look ATM?

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2024

https://stackoverflow.com/a/68102428/2504224

@geoand geoand self-assigned this Feb 2, 2024
@Serkan80
Copy link

Serkan80 commented Feb 3, 2024 •
edited
Loading

May I make a suggestion ? :)

@ClientBasicAuth(username=“${username}”, password=“${password}”)

or

@ClientHeaderParam(name=“Authorization”, value=“${username:password}”, isBasicAuth=true)

geoand added a commit to geoand/quarkus that referenced this issue Feb 6, 2024
@geoand
Introduce @ClientBasicAuth annotation
6993e3a 
This makes the use of basic authentication from
the REST client dead simple

Closes: quarkusio#38565
@geoand geoand mentioned this issue Feb 6, 2024
Merged
geoand added a commit that referenced this issue Feb 7, 2024
@geoand
Merge pull request #38603 from geoand/#38565
5d4e542 
Introduce @ClientBasicAuth annotation
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 7, 2024
@AnastasiiaL AnastasiiaL mentioned this issue Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/rest-client kind/enhancement New feature or request
Projects
None yet
Milestone
3.9.0.CR1
Development

Successfully merging a pull request may close this issue.

Introduce @ClientBasicAuth annotation geoand/quarkus
3 participants
@FroMage @geoand @Serkan80