Just having shamrock-agroal-deployment as dependency shouldn't require it to be configured

[Sanne]

In the process of adding new extensions to an existing demo, my first step was to add shamrock-agroal-deployment and then verify the build was still fine.

Tests actually fails with:

Caused by: java.lang.RuntimeException: org.jboss.shamrock.deployment.configuration.ConfigurationError: Required configuration property 'shamrock.datasource.driver' was not defined.
	at org.jboss.shamrock.runner.RuntimeRunner.run(RuntimeRunner.java:128)

I haven't configured it yet, but I'm also not really using Agroal yet so I hope we can improve on this.

[gsmet]

Additional info, the property is defined as:

    @ConfigProperty(name = "shamrock.datasource")
    Optional<DataSourceConfig> dataSourceConfig;

[stuartwdouglas]

That is a bug, but as @dmlloyd is working on changing all the configuration stuff anyway I am not sure if it is worth looking into at this point.

[Sanne]

it's ok, not urgent. Just need to track it.

[dmlloyd]

@Sanne is this fixed now?

[gsmet]

Hum. It's even worse now with my config changes.

Will fix.