Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Declare the test scope on test dependencies #108

Merged
merged 1 commit into from
Mar 18, 2019
Merged

[DO NOT MERGE] Declare the test scope on test dependencies #108

merged 1 commit into from
Mar 18, 2019

Conversation

cescoffier
Copy link
Member

Follow up from quarkusio/quarkus#1557

@cescoffier cescoffier requested a review from gsmet March 18, 2019 13:24
@cescoffier cescoffier changed the title Declare the test scope on test dependencies [DO NOT MERGE] Declare the test scope on test dependencies Mar 18, 2019
@cescoffier cescoffier mentioned this pull request Mar 18, 2019
Merged
gsmet
gsmet approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks, you beat me to it.

I think I'll reorganize dependencies a bit to have the test dependencies last for all our quickstarts.

@gsmet gsmet merged commit ad5a773 into quarkusio:development Mar 18, 2019
@gsmet
Copy link
Member

gsmet commented Mar 18, 2019

@cescoffier I merged it as it can be merged now. We don't need the main repo PR for it to work as we add more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cescoffier @gsmet