feat: apply CRD at built time if quarkus.operator-sdk.crd.apply=true
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling `quarkus.operator-sdk.crd.apply=true` at build time, we will register the CRD in the Kubernetes cluster where user is logged in. Updated documentation and added a note saying that this will always be done when running the application on Dev mode. Fix quarkiverse#242
metacosm
reviewed
Mar 7, 2022
core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/CRDConfiguration.java
Show resolved
Hide resolved
metacosm
added a commit
that referenced
this pull request
Jan 6, 2023
The rationale for this is that there's really no point in applying the CRDs at build time to a cluster that might not be the one where the code will run. Moreover, this also meant that CRDs would be applied twice. This reverts the behavior introduced by #260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling
quarkus.operator-sdk.crd.apply=trueat build time, we will register the CRD in the Kubernetes cluster where user is logged in.Updated documentation and added a note saying that this will always be done when running the application on Dev mode.
Fix #242