Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Bundle CSV annotations to be given via configuration #903

Closed
MikeEdgar opened this issue Jul 16, 2024 · 1 comment · Fixed by #947
Closed

Allow Bundle CSV annotations to be given via configuration #903

MikeEdgar opened this issue Jul 16, 2024 · 1 comment · Fixed by #947
Assignees
@metacosm

Comments

@MikeEdgar
Copy link
Contributor

We can currently add annotations to the CSV using @CSVMetadata, but some annotations are dynamic and would be better given via configs.

For example:

  • olm.skipRange
  • createdAt
  • containerImage (bundle generator could probably optionally figure this one out automatically)

Maybe a general purpose solution could be to allow configuration of arbitrary annotations via config like:

quarkus.operator-sdk.bundle.annotations."my-annotation"=annotation-value
@metacosm metacosm self-assigned this Aug 5, 2024
metacosm added a commit that referenced this issue Sep 5, 2024
@metacosm
feat: provide per-bundle configuration via properties
097c8b8 
Fixes #903

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm mentioned this issue Sep 5, 2024
Merged
@metacosm
Copy link
Member

metacosm commented Sep 5, 2024

Let me know if #947 addresses your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: provide per-bundle configuration via properties quarkiverse/quarkus-operator-sdk
2 participants
@metacosm @MikeEdgar