Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negative coordinates #1922

Open
wants to merge 55 commits into
base: qa
Choose a base branch
from
Open

Remove negative coordinates #1922

wants to merge 55 commits into from

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Sep 25, 2024

  • remove axes lines
  • clamp viewport to start
  • selection <-> excel-style coordinates
  • remove 0 and negative values from sheet offsets
  • show coordinates as A1 (with no options for the old coordinate style)
  • new generic message from core to client
  • new file version with shifted negative columns and rows
  • replace coordinates in Validations
  • replace coordinates in UI
  • keyboard should navigate properly
  • experiment with negative gray space again
  • connections cell ref (merge and update w/A1)
  • add errors to languages that highlight the lack of negative columns and rows
  • python API changes
  • JS API changes

Doc updates

  • remove all negative and (0, 0) references from docs
  • add page that describes why we moved away from (x, y) and negative offsets (include link in snackbar message)
  • language docs updates
  • upgrade all examples to 1.7.1 and ensure all cell references work properly
  • ensure all snippets use new positioning

Copy link

qa-wolf bot commented Sep 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 4, 2024 0:17am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 September 25, 2024 14:09 Inactive
@davidfig davidfig changed the base branch from qa to manipulate-column-row September 25, 2024 15:35
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 September 25, 2024 15:36 Inactive
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 94.48604% with 81 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (cc8fde0) to head (ebe1b29).

Files with missing lines Patch % Lines
quadratic-core/src/sheet_offsets/mod.rs 60.00% 24 Missing ⚠️
quadratic-core/src/a1.rs 92.39% 14 Missing ⚠️
quadratic-core/src/grid/file/mod.rs 50.00% 14 Missing ⚠️
quadratic-core/src/selection/mod.rs 94.16% 8 Missing ⚠️
quadratic-core/src/selection/selection_to_a1.rs 97.47% 5 Missing ⚠️
...rc/controller/execution/run_code/run_connection.rs 98.72% 3 Missing ⚠️
...adratic-core/src/grid/sheet/formats/format_cell.rs 66.66% 3 Missing ⚠️
quadratic-core/src/selection/selection_from_a1.rs 98.14% 3 Missing ⚠️
...ratic-core/src/sheet_offsets/sheet_offsets_wasm.rs 0.00% 3 Missing ⚠️
...ratic-core/src/grid/file/shift_negative_offsets.rs 97.61% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1922      +/-   ##
==========================================
+ Coverage   90.76%   90.89%   +0.12%     
==========================================
  Files         247      253       +6     
  Lines       54593    55604    +1011     
==========================================
+ Hits        49553    50540     +987     
- Misses       5040     5064      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 September 27, 2024 12:16 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 October 3, 2024 12:05 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 October 3, 2024 12:56 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 October 3, 2024 16:10 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1922 October 4, 2024 11:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants