Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

769 update crates versions #820

Merged
merged 24 commits into from
Oct 5, 2023
Merged

769 update crates versions #820

merged 24 commits into from
Oct 5, 2023

Conversation

ikopylov
Copy link
Member

@ikopylov ikopylov commented Jun 25, 2023

Closes #769
Closes #783
Closes #821

Copy link
Contributor

@idruzhitskiy idruzhitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idruzhitskiy
Copy link
Contributor

@ikopylov Tests are failing

@ikopylov
Copy link
Member Author

@ikopylov Tests are failing

The test failed because the node did not start during the timeout (https://github.com/qoollo/bob/actions/runs/6275842559/job/17044506550?pr=820#step:12:194). Perhaps there was an increased load on the CI runner at that moment and the node simply did not have CPU to start in time.
After running the tests again, the problem disappeared. I tried to run test 5 times in GitHub CI (https://github.com/qoollo/bob/actions/runs/6278923381) and the problem was not reproduced. Additionally I run Bob on test server and also didn't reproduce it.

# Conflicts:
#	bob-access/Cargo.toml
#	bob-apps/Cargo.toml
#	bob-backend/Cargo.toml
#	bob-common/Cargo.toml
#	bob-grpc/Cargo.toml
#	bob/Cargo.toml
@ikopylov ikopylov merged commit 928faef into master Oct 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move common dependencies into workspace Update Bytes crate version Update tokio and other crates versions
2 participants