Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests when batching is used in QuantumKernel #242

Closed
adekusar-drl opened this issue Oct 11, 2021 · 0 comments · Fixed by #306
Closed

Improve unit tests when batching is used in QuantumKernel #242

adekusar-drl opened this issue Oct 11, 2021 · 0 comments · Fixed by #306
Labels
priority: medium type: enhancement ✨ Features or aspects to improve

Comments

@adekusar-drl
Copy link
Collaborator

What is the expected enhancement?

Recently QuantumKernel was improved when a statevector simulator is used, see #209. This modification makes use of batch_size parameter. The unit tests does not verify that this parameter is used correctly cause such check requires intercepting the calls to QuantumInstance. This issue is raised to improve the tests in this regard. For more details see the above mentioned PR.
@adekusar-drl adekusar-drl added priority: medium type: enhancement ✨ Features or aspects to improve labels Oct 11, 2021
@adekusar-drl adekusar-drl mentioned this issue Oct 11, 2021
Merged
declanmillar added a commit to declanmillar/qiskit-machine-learning that referenced this issue Feb 8, 2022
@declanmillar
add unit tests for QuantumKernel batching (qiskit-community#242)
f04c628
declanmillar added a commit to declanmillar/qiskit-machine-learning that referenced this issue Feb 8, 2022
@declanmillar
update comment (qiskit-community#242)
043d4ec
@declanmillar declanmillar mentioned this issue Feb 8, 2022
Merged
adekusar-drl added a commit that referenced this issue Feb 11, 2022
@declanmillar @adekusar-drl
Add unit tests for QuantumKernel circuit batching (#306)
44bfc66 
* add unit tests for QuantumKernel batching (#242)

* update comment (#242)

* fix linter errors

* use TestCase signature in inheritance

* use double quotes

* fix copyright dates

* move declaration of circuits_counts to setUp

* remove class generator and override execute directly

* update function docstring

* update test class docstring

* patch instances not class

* fix style

* replace adhoc data and comment on source

* remove test data and update comment

Co-authored-by: Anton Dekusar <62334182+adekusar-drl@users.noreply.github.com>
oscar-wallis pushed a commit that referenced this issue Feb 16, 2024
@declanmillar @adekusar-drl
Add unit tests for QuantumKernel circuit batching (#306)
c43031f 
* add unit tests for QuantumKernel batching (#242)

* update comment (#242)

* fix linter errors

* use TestCase signature in inheritance

* use double quotes

* fix copyright dates

* move declaration of circuits_counts to setUp

* remove class generator and override execute directly

* update function docstring

* update test class docstring

* patch instances not class

* fix style

* replace adhoc data and comment on source

* remove test data and update comment

Co-authored-by: Anton Dekusar <62334182+adekusar-drl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium type: enhancement ✨ Features or aspects to improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests for QuantumKernel circuit batching declanmillar/qiskit-machine-learning
1 participant
@adekusar-drl