Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Pytorch backend #30

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Move Pytorch backend #30

wants to merge 5 commits into from

Conversation

Simone-Bordoni
Copy link
Collaborator

Move pytorch backend from qibo to qiboml

@Simone-Bordoni Simone-Bordoni added the enhancement New feature or request label Jul 17, 2024
@Simone-Bordoni Simone-Bordoni self-assigned this Jul 17, 2024
@Simone-Bordoni
Copy link
Collaborator Author

We should wait for the new release of qibo in order to merge

@MatteoRobbiati
Copy link
Contributor

We should wait for the new release of qibo in order to merge

Do you think now we can update this and merge @Simone-Bordoni? :)

@MatteoRobbiati
Copy link
Contributor

I think now the tests should pass. The backend migrated here is updated with Qibo and a couple of errors have been fixed. Have a look whenever you can @BrunoLiegiBastonLiegi and imho we can merge it.

@BrunoLiegiBastonLiegi
Copy link
Contributor

Honestly, I am not sure whether it is worth rushing this by friday. As I see it, there are still two relevant matters open:

  • what to do with the tests? Do we leave them in qibo, thus creating the same ongoing problems we have with qibojit as well, or do we try to solve this once and for all, maybe splitting the tests in the different repos as we were discussing earlier in the meeting?
  • The PyTorchBackend is not really working for what it's more important (the gradients) Fix pytorch gradients qibo#1450, thus we would be moving something buggy anyway

@MatteoRobbiati
Copy link
Contributor

Honestly, I am not sure whether it is worth rushing this by friday. As I see it, there are still two relevant matters open:

  • what to do with the tests? Do we leave them in qibo, thus creating the same ongoing problems we have with qibojit as well, or do we try to solve this once and for all, maybe splitting the tests in the different repos as we were discussing earlier in the meeting?
  • The PyTorchBackend is not really working for what it's more important (the gradients) Fix pytorch gradients qibo#1450, thus we would be moving something buggy anyway

I am fine in re-discussing the testing strategy and so post-poning this to next releases. Both your comments are correct and I agree. Anyway, it is useful if we merge this here, no? (without the need of rushing for the migration)

@BrunoLiegiBastonLiegi
Copy link
Contributor

Yes we can, I mean qiboml is quite a work in progress in any case right now and even the main is not really tested, but I am not sure what this buys us. We will need to open a new PR for the PyTorchBackend in any case as soon the gradients problem gets fixed.

@MatteoRobbiati
Copy link
Contributor

Yes we can, I mean qiboml is quite a work in progress in any case right now and even the main is not really tested, but I am not sure what this buys us. We will need to open a new PR for the PyTorchBackend in any case as soon the gradients problem gets fixed.

Ok, fine. We can keep this open until that moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants