Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryoscope #974

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Cryoscope #974

wants to merge 15 commits into from

Conversation

andrea-pasquale
Copy link
Contributor

I'm currently using this protocol to calibrate the filters of QM.
It is not precisely a cryoscope but I'm just fitting with an exponential the time of rise and then I apply the corresponding FIR and IIR filters.

  • Improve documentation
  • Move post-processing in fit

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 40.16393% with 73 lines in your changes missing coverage. Please review.

Project coverage is 96.77%. Comparing base (c4fdce8) to head (dc99101).

Files with missing lines Patch % Lines
...bocal/protocols/two_qubit_interaction/cryoscope.py 36.52% 73 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   97.50%   96.77%   -0.74%     
==========================================
  Files         123      124       +1     
  Lines        9701     9820     +119     
==========================================
+ Hits         9459     9503      +44     
- Misses        242      317      +75     
Flag Coverage Δ
unittests 96.77% <40.16%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/__init__.py 100.00% <ø> (ø)
...ibocal/protocols/two_qubit_interaction/__init__.py 100.00% <100.00%> (ø)
...ibocal/protocols/two_qubit_interaction/optimize.py 97.75% <ø> (ø)
...rotocols/two_qubit_interaction/virtual_z_phases.py 95.67% <100.00%> (+0.08%) ⬆️
...bocal/protocols/two_qubit_interaction/cryoscope.py 36.52% <36.52%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant