Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pyupgrade #22

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Adding pyupgrade #22

merged 1 commit into from
Aug 8, 2022

Conversation

andrea-pasquale
Copy link
Contributor

Adding pyupgrade to the pre-commit hooks as we did for qibo (qiboteam/qibo#633).

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #22 (d715dc3) into main (706ec50) will increase coverage by 21.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #22       +/-   ##
===========================================
+ Coverage   41.58%   63.51%   +21.92%     
===========================================
  Files           9        4        -5     
  Lines         202       74      -128     
===========================================
- Hits           84       47       -37     
+ Misses        118       27       -91     
Flag Coverage Δ
unittests 63.51% <ø> (+21.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qcvv/calibrations/utils.py
src/qcvv/cli/_base.py
src/qcvv/calibrations/__init__.py
src/qcvv/calibrations/resonator_spectroscopy.py
src/qcvv/cli/__init__.py

@scarrazza
Copy link
Member

Thanks, given this repo is private, did you try to run pre commit manually?

@andrea-pasquale
Copy link
Contributor Author

I've executed

pre-commit run pyupgrade --all-files

which should run pyupgrade also on the unstaged files.
Also to me it was quite strange that it didn't change anything.
Did you do the same for qibo?

@scarrazza
Copy link
Member

Yes, that's correct, thanks. Let's merge.

@scarrazza scarrazza merged commit f7f58cf into main Aug 8, 2022
@scarrazza scarrazza deleted the pyupgrade branch August 17, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants