Fix engine not renamed to platform in some tests #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `test_prints.py` when cuquantum is installed
stavros11
reviewed
Jan 19, 2022
| @@ -50,7 +50,7 @@ def test_backend_methods_list(tested_backend, target_backend, method, args): | |||
| tested_func = getattr(tested_backend, method) | |||
| target_func = getattr(target_backend, method) | |||
| target_result = target_func(*args) | |||
| if tested_backend.name == "qibojit" and tested_backend.engine.name in ["cupy", "cuquantum"]: # pragma: no cover | |||
| if tested_backend.name == "qibojit" and tested_backend.platform.name in ["cupy", "cuquantum"]: # pragma: no cover | |||
There was a problem hiding this comment.
This change is done in #533, in fact I completely removed this if and updated the casting below so that it works with all backends/platforms and we don't have to modify it every time we update something in qibojit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests the old
enginemember ofJitCustomBackendwas still used. I renamed it toplatform.