-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add T, S gates #525
Add T, S gates #525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 85 85
Lines 12284 12439 +155
==========================================
+ Hits 12284 12439 +155
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ok, I added the tests, now it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this. There is a test file called test_core_circuit_qasm.py
where we create circuits from qasm in qibo and cirq and we verify that their execution agrees. Since qasm was the original motivation of this PR, I would suggest to add a test involving these gates there. Other than that, everything looks good.
I implemented your suggestions. Let me know if you agree with the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this implementation.
LGTM.
Hi all, I know that you made great work and these gates are functional. However, the |
Closes #524. I added S and T, along with their conjugate transpose SDG and TDG. Still need to update the tests.