Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AAVQE example with qibotf #507

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix AAVQE example with qibotf #507

merged 1 commit into from
Nov 8, 2021

Conversation

mlazzarin
Copy link
Contributor

Closes #502.

@mlazzarin mlazzarin added the bug Something isn't working label Nov 8, 2021
scarrazza
scarrazza approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlazzarin thanks, looks good to me.

stavros11
stavros11 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just to keep in mind that once we merge this, we should merge the new master to #475 and fix the conflict (use the K.real version there).

@scarrazza scarrazza merged commit 0f606c7 into master Nov 8, 2021
@scarrazza scarrazza deleted the fixaavqetf branch February 11, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarrazza scarrazza scarrazza approved these changes

@stavros11 stavros11 stavros11 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AAVQE example is not working with qibotf
3 participants
@mlazzarin @scarrazza @stavros11