Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flag from AbstractCircuit class #463

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Remove unused flag from AbstractCircuit class #463

merged 1 commit into from
Sep 10, 2021

Conversation

mlazzarin
Copy link
Contributor

Closes #462. I added some edits that came to my mind while reading abstractions/circuit.py, let me know if they are ok or if I should undo them.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #463 (31a603b) into master (4073ce9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #463   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines        11867     11866    -1     
=========================================
- Hits         11867     11866    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/abstractions/circuit.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4073ce9...31a603b. Read the comment docs.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlazzarin thank you. This looks good to me, I have recompiled the docs and the links are working properly.

@scarrazza scarrazza merged commit 28171d2 into master Sep 10, 2021
@scarrazza scarrazza deleted the rm_flag branch September 18, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag "is_executed" is defined but not implemented
2 participants